@jeff-phillips-18 we may have some conflict or confusion around the existing alerts product features around line 1902 in that file. Is this new UI code going to replace the policy alerts area?

@h-kataria can you take a look to see if there will be an conflicts or overlap with the existing features?

Thanks @dclarizio. The existing Alerts is under Policy. Should I put the new Alerts section under Monitor then? The navigation model will be Monitor -> Alerts -> Overview... Hopefully differently nested names don't conflict.

@jeff-phillips-18 I would think it would be better under Monitor, as we try to make the features tree follow the UI menus as much as possible. The nesting doesn't avoid conflict, each feature must have a unique ID.

@dclarizio I've updated the identifiers and put the new Alerts sections under the parent Monitor section.

@dclarizio Should this file be moved to the https://github.com/ManageIQ/manageiq-ui-classic repo?

@dclarizio looks good, identifiers in this PR have uniq ids and do not have any conflict with existing feature ids

@chessbyte

@dclarizio Should this file be moved to the https://github.com/ManageIQ/manageiq-ui-classic repo?

I don't think so, since it controls access across all UIs and the API.

@jeff-phillips-18 Can you post a screenshot of where this appears in the Product Features tree on the Role screen in Configuration? Asking, because it should match where it appears in the navigation tabs, as we try to mimic that order to make it more usable (I don't know where Monitoring will be placed).
Thx, Dan

@dclarizio This mimics the plan for the navigation:

@jeff-phillips-18 +1 that Alerts should be under Monitor and Monitor should be the last item in primary navigation

Underneath Alerts should be:
Overview
All Alerts
Most Recent Alerts
Top Triggers ( although this may not have been implemented yet )

@jeff-phillips-18 @dclarizio ^^

@dclarizio @serenamarie125 Update:

We can add Top Triggers once we are closer to doing the UI work for it.

Checked commits jeff-phillips-18/manageiq@a385530~...0ed82be with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1
0 files checked, 0 offenses detected
Everything looks good. 🏆

@jeff-phillips-18 looks good.
@serenamarie125 it looks like there are not CRUD actions at this time, but that's fine as new functions can be easily added in the future as needed.
@chessbyte this looks ready to merge to me.

@miq-bot assign @chessbyte